GEODE-10047: Correct logging to report configured expiration interval #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Donal Evans <doevans@vmware.com>
DonalEvans
requested review from
jdeppe-pivotal,
nonbinaryprogrammer,
ringles,
upthewaterspout and
dschneider-pivotal
as code owners
geode-for-redis/src/main/java/org/apache/geode/redis/internal/statistics/RedisStats.java
Show resolved
Hide resolved
...r-redis/src/main/java/org/apache/geode/redis/internal/services/PassiveExpirationManager.java
Outdated
Show resolved
Hide resolved
- Restore removed methods from RedisStats Authored-by: Donal Evans <doevans@vmware.com>
nonbinaryprogrammer
approved these changes
Feb 15, 2022
dschneider-pivotal
approved these changes
Feb 15, 2022
DonalEvans
deleted the
feature/GEODE-10047-passive-expiration-logging
branch
DonalEvans
added a commit
that referenced
this pull request
Feb 15, 2022
- Change naming of passive expiration to active expiration throughout the geode-for-redis module so as to be consistent with Redis' language - Replace hard-coded expiration interval of 1 second with a reference to the configured expiration interval in log message in PassiveExpirationManager (now named ActiveExpirationManager) Authored-by: Donal Evans <doevans@vmware.com> (cherry picked from commit cd0b52e)
There was a problem hiding this comment.
As per https://cwiki.apache.org/confluence/display/GEODE/Commit+Message+Format, first commit summary should be under 29 characters (not including bug# or pr#) (yours is 56 characters) and details should explain what the intent of the commit is and why. If you amend your initial commit now and force-push, you can benefit from review feedback on your commit message, and you won't have to remember to fix it later when you merge.
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 11, 2022
- Change naming of passive expiration to active expiration throughout the geode-for-redis module so as to be consistent with Redis' language - Replace hard-coded expiration interval of 1 second with a reference to the configured expiration interval in log message in PassiveExpirationManager (now named ActiveExpirationManager) Authored-by: Donal Evans <doevans@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored-by: Donal Evans doevans@vmware.com
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?