GEODE-9950: Add LRANGE command #7389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kris-10-0
requested review from
jdeppe-pivotal,
nonbinaryprogrammer,
ringles,
upthewaterspout,
DonalEvans and
dschneider-pivotal
as code owners
jdeppe-pivotal
requested changes
Feb 23, 2022
...va/org/apache/geode/redis/internal/commands/executor/list/AbstractLRangeIntegrationTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/geode/redis/internal/commands/executor/list/AbstractLRangeIntegrationTest.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
Kris-10-0
force-pushed
the
feature/GEODE-9950
branch
from
0887879
to
7f8eaff
Compare
Kris-10-0
force-pushed
the
feature/GEODE-9950
branch
4 times, most recently
from
2fb8625
to
82faff1
Compare
dschneider-pivotal
requested changes
Feb 25, 2022
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
Kris-10-0
force-pushed
the
feature/GEODE-9950
branch
from
11ed0b7
to
903932b
Compare
DonalEvans
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
A few suggestions, but none of them are mandatory. If you don't want to go to the trouble of refactoring the tests to be parameterized, then some clarification in the test names around whether the range being tested is valid (expected to contain elements) or invalid (expected to be empty) would be good, to avoid potential confusion.
...dis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LRangeExecutor.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
...va/org/apache/geode/redis/internal/commands/executor/list/AbstractLRangeIntegrationTest.java
Outdated
Show resolved
Hide resolved
Kris-10-0
force-pushed
the
feature/GEODE-9950
branch
from
903932b
to
45e041b
Compare
dschneider-pivotal
approved these changes
Mar 1, 2022
Kris-10-0
force-pushed
the
feature/GEODE-9950
branch
from
857b278
to
de81685
Compare
jdeppe-pivotal
approved these changes
Mar 4, 2022
Kris-10-0
force-pushed
the
feature/GEODE-9950
branch
from
de81685
to
7230d15
Compare
This implements a version of the Redis LRANGE command, which is used for list data types. Associated tests were also added. Given a key, it returns a list of elements in the range (inclusive) for the specified start index and stop index. Both the start and stop indexes are zero based, which starts at the head of the list. Negative indexes start at the tail of the list. LINDEX was modified to use a new method created in this commit. The method converts negative indexes to the corresponding positive index.
implementation of iteration through list.
Kris-10-0
force-pushed
the
feature/GEODE-9950
branch
from
7230d15
to
8537733
Compare
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 11, 2022
This implements a version of the Redis LRANGE command, which is used for list data types. Associated tests were also added. Given a key, it returns a list of elements in the range (inclusive) for the specified start index and stop index. Both the start and stop indexes are zero based, which starts at the head of the list. Negative indexes start at the tail of the list. LINDEX was modified to use a new method created in this commit. The method converts negative indexes to the corresponding positive index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a version of the Redis LRANGE command, which is used for list data types. Associated tests were also added.
Given a key, it returns a list of elements in the range (inclusive) for the specified start index and stop index. Both the start and stop indexes are zero based, which starts at the head of the list. Negative indexes start at the tail of the list.
LINDEX was modified to use a new method created in this commit. The method converts negative indexes to the corresponding positive index.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?