Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-10127: Use correct hostname in WAN with LB test #7465

Conversation

upthewaterspout
Copy link
Contributor

This test is making gateway sender side members to connect to the receiver side
through a load balance. This test used "localhost" as the hostname for
clients. That worked previously, because we were actually losing the
hostname-for-clients in the RemoteLocatorResponse, and instead sending the IP
address, due to the changes in GEODE-8955.

With the fix for GEODE-10127, we are now correctly sending the
hostname-for-clients to the gateway sender, and so
now "localhost" doesn't work. The correct hostname-for-clients is the IP
address we get from docker-compose.

Changing the test to pass the IP address instead of "localhost" to the receiver
locator, just like we do for the receivers themselves.

Re-enabling the test

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

This test is making gateway sender side members to connect to the receiver side
through a load balance.  This test used "localhost" as the hostname for
clients. That worked previously, because we were actually losing the
hostname-for-clients in the RemoteLocatorResponse, and instead sending the IP
address, due to the changes in GEODE-8955.

With the fix for GEODE-10127, we are now correctly sending the
hostname-for-clients to the gateway sender, and so
now "localhost" doesn't work. The correct hostname-for-clients is the IP
address we get from docker-compose.

Changing the test to pass the IP address instead of "localhost" to the receiver
locator, just like we do for the receivers themselves.

Re-enabling the test
Replacing the gfsh scripts in the
SeveralGatewayReceiversWithSamePortAndHostnameForSendersTest with inline gfsh
-e statements in the java code.
@nabarunnag
Copy link
Contributor

Dan can we still use hostnames for --hostname-for-clients or it has to be IP always. Is this change just only for Docker compose case

@upthewaterspout
Copy link
Contributor Author

@nabarunnag - In general hostname-for-clients should be a hostname, especially if you are using TLS. However, IP addresses should also work - we should just be passing whatever is in hostname-for-clients all the way to the client/gateway sender.

I'm not clear enough about networking with docker compose to know if there is a hostname we could use in this case instead of the IP address, but maybe there is something?

@upthewaterspout upthewaterspout merged commit c175096 into apache:develop Mar 23, 2022
@upthewaterspout upthewaterspout deleted the feature/reenable-wan-behind-proxy-test-GEODE-10127 branch March 23, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants