GEODE-10134: Add JDK 17 proxy classes to serialization accept list #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jar deployment serializes proxies. JDK 17 creates proxy classes in dynamically created packages with names like `jdk.proxy2` and `jdk.proxy3`.
demery-pivotal
added
windows
|
NOTE: This fixes all of the deployment-related distributed tests on JDK 17. All other JDK 17 test failures are expected for now, and will be fixed later PRs. |
jchen21
reviewed
Mar 23, 2022
| @@ -98,6 +98,7 @@ private static StringJoiner dependenciesPattern() { | |||
|
|
|||
| // jar deployment | |||
| .add("com.sun.proxy.$Proxy*") | |||
| .add("jdk.proxy*") | |||
There was a problem hiding this comment.
Will jdk.proxy*.$Proxy* work?
There was a problem hiding this comment.
Unfortunately, no. The filter matcher pattern is not a regular expression. See the rules for the filter pattern here: https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/ObjectInputFilter.Config.html#createFilter(java.lang.String)
There was a problem hiding this comment.
Yeah. Seems like the number in the class name could be up to jdk.proxy6. Adding jdk.proxy* is good.
jchen21
approved these changes
Mar 24, 2022
demery-pivotal
deleted the
geode-10134/serializables-filter-proxy-pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jar deployment serializes proxies. JDK 17 creates proxy classes in
dynamically created packages with names like
jdk.proxy2andjdk.proxy3.