GEODE-10191: Radish RENAME and RESTORE create notification events #7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Both of these commands have the ability to create events to satisfy BLPOP. - Introduce a NotificationEvent enum which is passed to fireEvent. - Previously the RedisCommandType was being passed, but this does not work for RENAME which creates RENAME_FROM and RENAME_TO events. In the future, other commands will need to create multiple events too.
jdeppe-pivotal
requested review from
nonbinaryprogrammer,
ringles,
upthewaterspout,
DonalEvans and
dschneider-pivotal
as code owners
DonalEvans
approved these changes
Mar 31, 2022
jmelchio
pushed a commit
to jmelchio/geode
that referenced
this pull request
Apr 1, 2022
…ache#7537) - Both of these commands have the ability to create events to satisfy BLPOP. - Introduce a NotificationEvent enum which is passed to fireEvent. - Previously the RedisCommandType was being passed, but this does not work for RENAME which creates RENAME_FROM and RENAME_TO events. In the future, other commands will need to create multiple events too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLPOP.
work for RENAME which creates RENAME_FROM and RENAME_TO events. In the
future, other commands will need to create multiple events too.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?