GEODE-10261: VMProvider.invokeAsync uses appropriate parameterization. #7631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yozaner1324
requested review from
mhansonp,
kirklund,
DonalEvans,
jake-at-work,
jdeppe-pivotal,
jinmeiliao,
gesterzhou,
boglesby,
nabarunnag,
dschneider-pivotal,
agingade,
jchen21,
upthewaterspout,
pivotal-eshu,
BenjaminPerryRoss,
Bill,
echobravopapa and
kamilla1201
as code owners
DonalEvans
reviewed
Apr 28, 2022
There was a problem hiding this comment.
Great clean-up! At the risk of adding more work, if you do an IntelliJ search for AsyncInvocation[^<;] with case sensitivity and regex matching enabled and filter the results to "Except Comments and String Literals", you can find all the places in the codebase that AsyncInvocation is used without parameterization. There only seem to be about 20 classes left, so with a bit more work, you could eliminate all of the places where this class is used without parameterization.
...a/org/apache/geode/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
Outdated
Show resolved
Hide resolved
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PutAllGlobalDUnitTest.java
Outdated
Show resolved
Hide resolved
...he/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDistributedTest.java
Outdated
Show resolved
Hide resolved
geode-core/src/distributedTest/java/org/apache/geode/management/DiskManagementDUnitTest.java
Outdated
Show resolved
Hide resolved
...e-dunit/src/distributedTest/java/org/apache/geode/test/dunit/tests/BasicDistributedTest.java
Outdated
Show resolved
Hide resolved
geode-dunit/src/distributedTest/java/org/apache/geode/test/dunit/tests/VMDistributedTest.java
Outdated
Show resolved
Hide resolved
jake-at-work
approved these changes
Apr 28, 2022
jinmeiliao
approved these changes
Apr 28, 2022
jmelchio
approved these changes
Apr 28, 2022
yozaner1324
force-pushed
the
GEODE-10261
branch
2 times, most recently
from
39f2ce5
to
4115723
Compare
DonalEvans
approved these changes
Apr 29, 2022
kirklund
reviewed
May 4, 2022
...e-dunit/src/distributedTest/java/org/apache/geode/test/dunit/tests/BasicDistributedTest.java
Outdated
Show resolved
Hide resolved
kirklund
approved these changes
May 4, 2022
yozaner1324
force-pushed
the
GEODE-10261
branch
3 times, most recently
from
8364a87
to
c077a23
Compare
mhansonp
approved these changes
May 11, 2022
dschneider-pivotal
approved these changes
May 17, 2022
mkevo
approved these changes
May 18, 2022
upthewaterspout
approved these changes
May 23, 2022
There was a problem hiding this comment.
Looks good. If you can, please update the description with a little more detail on what you changed. For example:
Add generic parameters to AsyncInvocation variables where they were missing.
Cleaned up places where there was array of size 1 when it could have just been a variable.
Thanks!
demery-pivotal
approved these changes
Jun 6, 2022
gesterzhou
approved these changes
Jun 10, 2022
jchen21
approved these changes
Jun 10, 2022
agingade
approved these changes
Jun 10, 2022
boglesby
approved these changes
Jun 10, 2022
* Cleanup use of AsyncInvocation. * Add generic parameters to AsyncInvocation variables where they were missing. * Cleaned up by changing single element arrays to variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?