GEODE-10278: Remove the geode-for-redis module #7657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the geode-for-redis module. This commit is just the module itself, not the related documentation and CI scripts.
Removing geode-for-redis from all of the places that reference it - CI, scripts, docs, expected assembly and pom context.
upthewaterspout
requested review from
pivotal-amurmann,
kirklund,
rhoughton-pivot,
dickcav,
smgoller,
jdeppe-pivotal,
nonbinaryprogrammer,
ringles,
DonalEvans,
dschneider-pivotal and
mhansonp
as code owners
upthewaterspout
changed the title
agingade
approved these changes
May 4, 2022
onichols-pivotal
approved these changes
May 4, 2022
dickcav
approved these changes
May 4, 2022
pivotal-amurmann
approved these changes
May 4, 2022
DonalEvans
approved these changes
May 4, 2022
kirklund
approved these changes
May 4, 2022
davebarnes97
approved these changes
May 4, 2022
jdeppe-pivotal
approved these changes
May 4, 2022
smgoller
approved these changes
May 5, 2022
rhoughton-pivot
approved these changes
May 5, 2022
dschneider-pivotal
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the geode-for-redis module and related documentation.
To make this easier to review, I split out the change that just deletes the geode-for-redis directory into a separate commit.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?