GEODE-10106: Use queueConnection snapshot for if #7740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabarunnag
requested review from
Bill,
echobravopapa,
kamilla1201 and
jake-at-work
as code owners
gesterzhou
approved these changes
May 31, 2022
jake-at-work
requested changes
Jun 1, 2022
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java
Outdated
Show resolved
Hide resolved
nabarunnag
force-pushed
the
feature/GEODE-10106
branch
from
259ad01
to
5cd3e6e
Compare
jake-at-work
approved these changes
Jun 1, 2022
| @@ -966,6 +965,16 @@ public void recoverPrimary(Set<ServerLocation> excludedServers) { | |||
| } | |||
| } | |||
|
|
|||
| private boolean isPrimaryRecoveryNeeded(final ConnectionList queueConnectionList) { | |||
There was a problem hiding this comment.
If you make this static you could easily create unit tests that could test all the paths in this method.
There was a problem hiding this comment.
@pivotal-jbarrett done, all branches are covered now.
nabarunnag
force-pushed
the
feature/GEODE-10106
branch
4 times, most recently
from
d294487
to
8f78eeb
Compare
jake-at-work
approved these changes
Jun 2, 2022
| @@ -966,6 +965,17 @@ public void recoverPrimary(Set<ServerLocation> excludedServers) { | |||
| } | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| public static boolean isPrimaryRecoveryNeeded(final ConnectionList queueConnectionList) { | |||
There was a problem hiding this comment.
For unit tests in the same package this doesn't need to be public. Then you can also drop the annotation.
* Using queueConnection local ref for multiple if checks * As it is a volatile variable, the value may become null mid checks.
nabarunnag
force-pushed
the
feature/GEODE-10106
branch
from
8f78eeb
to
86a4472
Compare
nabarunnag
added a commit
that referenced
this pull request
Jun 7, 2022
* Using queueConnection local ref for multiple if checks * As it is a volatile variable, the value may become null mid checks. (cherry picked from commit b16dafa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?