-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-10020: For Ping task avoid registering new destination endpoint #7749
Conversation
e48432e
to
4553799
Compare
await().untilAsserted(() -> assertThat(getQueuedEvents(vm1, senderId)).isEqualTo(0)); | ||
|
||
await().untilAsserted(() -> assertThat(getSenderPoolDisconnects(vm1, senderId)).isEqualTo(0)); | ||
|
||
await().untilAsserted(() -> assertThat(getPoolEndPointSize(vm1, senderId)).isEqualTo(1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can combine these into one await() if you want to:
await().untilAsserted(() -> {
assertThat(getQueuedEvents(vm1, senderId)).isEqualTo(0);
assertThat(getSenderPoolDisconnects(vm1, senderId)).isEqualTo(0);
assertThat(getPoolEndPointSize(vm1, senderId)).isEqualTo(1);
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for comments. Updated.
Hi |
…apache#7749) * GEODE-10020: For Ping task avoid registering new destination endpoint
…apache#7749) * GEODE-10020: For Ping task avoid registering new destination endpoint
For all changes:
[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[*] Has your PR been rebased against the latest commit within the target branch (typically
develop
)?[*] Is your initial contribution a single, squashed commit?
[*] Does
gradlew build
run cleanly?[*] Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?