GEODE-10352: Update Ruby version in Geode doc preview tool #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script to preview the documentation of Geode (./preview-user-guide.sh) is not working anymore. The following error appears while running it (unless you have a previously downloaded geodedocs/temp docker image in your local docker repo): ERROR: Error installing elasticsearch: The last version of faraday (>= 0) to support your Ruby & RubyGems was 1.10.0. Try installing it with `gem install faraday -v 1.10.0` and then running the current command again faraday requires Ruby version >= 2.6. The current ruby version is 2.5.9.229. That error prevents the preview script to work. It is needed to update the docker image used to preview the documentation to use a Ruby version >= 2.6. The versions of other gems also need to be updated after the change of the Ruby version.
davebarnes97
reviewed
Jun 2, 2022
There was a problem hiding this comment.
@albertogpz Thanks for your contribution. I am experiencing problems verifying this fix. Will report back when I have some helpful info to convey.
albertogpz
added a commit
that referenced
this pull request
Sep 16, 2022
The script to preview the documentation of Geode (./preview-user-guide.sh) is not working anymore. The following error appears while running it (unless you have a previously downloaded geodedocs/temp docker image in your local docker repo): ERROR: Error installing elasticsearch: The last version of faraday (>= 0) to support your Ruby & RubyGems was 1.10.0. Try installing it with `gem install faraday -v 1.10.0` and then running the current command again faraday requires Ruby version >= 2.6. The current ruby version is 2.5.9.229. That error prevents the preview script to work. It is needed to update the docker image used to preview the documentation to use a Ruby version >= 2.6. The versions of other gems also need to be updated after the change of the Ruby version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script to preview the documentation of Geode (./preview-user-guide.sh)
is not working anymore.
The following error appears while running it (unless you have a previously downloaded
geodedocs/temp docker image in your local docker repo):
ERROR: Error installing elasticsearch:
The last version of faraday (>= 0) to support your Ruby & RubyGems was 1.10.0. Try installing it with
gem install faraday -v 1.10.0and then running the current command againfaraday requires Ruby version >= 2.6. The current ruby version is 2.5.9.229.
That error prevents the preview script to work.
It is needed to update the docker image used to preview the documentation to use a Ruby version >= 2.6.
The versions of other gems also need to be updated after the
change of the Ruby version.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?