Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-10366: Cleanup GfshRule created Folder #7791

Closed

Conversation

kirklund
Copy link
Contributor

@kirklund kirklund commented Jun 9, 2022

PROBLEM

Tests using GfshRule default constructor do not delete the contents
of the internal Folder created by GfshRule when all tests passed. This
results in unnecessary size bloating of the archive file.

SOLUTION

Ensure that GfshRule handles Folder policy and invokes delete when
appropriate.

Copy link
Contributor

@onichols-pivotal onichols-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opting-in to automated commit message feedback via COMMITWATCHERS. https://cwiki.apache.org/confluence/display/GEODE/Commit+Message+Format suggests that your first commit additional detail paragraph(s) should describe the problem and how this change solves it.

These suggestions are totally optional. What matters is including enough detail for future contributors to understand what you intended and why.

Copy link
Contributor

@onichols-pivotal onichols-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to code freeze, please hold off merging this

@kirklund kirklund closed this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants