GEODE-3539: Add missing test coverage for 'describe connection' command. #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New test failed in precheckin failed due to IPv4 vs IPv6 discrepancy. Correction pending. |
PurelyApplied
force-pushed
the
geode-3539-describe.connection
branch
2 times, most recently
from
98e3bbf
to
521a93c
Compare
jaredjstewart
requested changes
Nov 2, 2017
| Enumeration<NetworkInterface> networkInterfaces = NetworkInterface.getNetworkInterfaces(); | ||
| NetworkInterface myInterface = networkInterfaces.nextElement(); | ||
| Enumeration<InetAddress> myAddresses = myInterface.getInetAddresses(); | ||
| return StreamSupport |
There was a problem hiding this comment.
Since this Enumeration will be reliably bounded (finite), I think we can turn it into a stream more concisely:
Collections.list(myAddresses).stream()
.map(InetAddress::getHostAddress)
.map(address -> formatAddressAndPort(address, locator.getJmxPort())).toArray(String[]::new);
There was a problem hiding this comment.
That's much less cudgel-y! Thanks.
| } | ||
| } | ||
| failWithMessage("No accepted value found."); | ||
| return null; |
There was a problem hiding this comment.
I think you can still return this rather than returning null. (For instance, someone might be using a JUnit rule that gathers up exceptions and re-throws them at the end of a sequence of operations. We wouldn't want to give them a NPE here in that case.)
There was a problem hiding this comment.
I hadn't even considered that scenario. Done and done.
|
Looks good overall! |
PurelyApplied
force-pushed
the
geode-3539-describe.connection
branch
from
5dcd783
to
24c7c1f
Compare
pdxrunner
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precheckin running.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.