simpler algorithm for hex id generation (avoid substring)

apache · Jun 4, 2018 · f0d6172 · f0d6172
1 parent 981f111
commit f0d6172
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...ing-impl/src/main/java/org/apache/geronimo/microprofile/opentracing/impl/IdGenerator.java b/...ing-impl/src/main/java/org/apache/geronimo/microprofile/opentracing/impl/IdGenerator.java
@@ -57,15 +57,16 @@ public Object get() {
             default:
                 delegate = new Supplier<Object>() {
                     private final Random random = new Random(System.nanoTime());
+                    private final char[] hexDigits = "0123456789abcdef".toCharArray();
                     private final String constantPart = config.read("id.generator.hex.prefix", "");
 
                     @Override
                     public Object get() {
                         final StringBuilder sb = new StringBuilder(16).append(constantPart);
-                        while (sb.length() < 16) {
-                            sb.append(Integer.toHexString(random.nextInt()));
+                        for (int i = 0; i < 16 - constantPart.length(); i++) {
+                            sb.append(hexDigits[random.nextInt(16)]);
                         }
-                        return sb.length() > 16 ? sb.substring(0, 16) : sb.toString();
+                        return sb.toString();
                     }
                 };
         }