This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
GIRAPH-1132 Giraph jobs don't end if zookeeper dies before job starts #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majakabiljo
approved these changes
Mar 1, 2017
| * Since we should never really have to wait forever. | ||
| * We should only wait some reasonable but large amount of time. | ||
| */ | ||
| LongConfOption WAIT_FOREVER_ZOOKEEPER_TIMEOUT_MSEC = |
There was a problem hiding this comment.
Nit: since we are not waiting forever anymore, I'd drop word forever from everywhere (forever and timeout have opposite meaning :-))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure I set all the timeouts right. There is no way to test all of these either.
The idea is that we shouldn't have infinite wait loops anywhere. And that's exactly what this diff does