This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
GIRAPH-1200: Add counters for network request resends #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlogothetis
reviewed
Sep 18, 2018
| // Check if there are open requests which have been sent a long time ago, | ||
| // and if so, resend them. | ||
| List<ClientRequestId> addedRequestIds = Lists.newArrayList(); | ||
| List<RequestInfo> addedRequestInfos = Lists.newArrayList(); | ||
| // Check all the requests for problems | ||
| // Check all the requests for problemsAggregate vertices |
There was a problem hiding this comment.
This comment doesn't look right
dlogothetis
approved these changes
Sep 18, 2018
Summary: Expose statistics around network requests which we had to resend. Test Plan: Ran a normal job, these counters were 0. Ran a job with very low request timeouts and verified these counters got populated.
majakabiljo
force-pushed
the
giraph-1200
branch
from
9ef72dd
to
7c619ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Expose statistics around network requests which we had to resend.
Test Plan: Ran a normal job, these counters were 0. Ran a job with very low request timeouts and verified these counters got populated.