-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/simple data writer #123
Conversation
|
||
import gobblin.configuration.ConfigurationKeys; | ||
import gobblin.configuration.State; | ||
import gobblin.util.ForkOperatorUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of unnecessary imports.
Add tests Refactor simple data writer Add the final output path to the task properties Update header comment Check return value of this.fs.delete Prepend this. to class variables Add license header Change test port from 8080 to 8000 so we don't have a colision on Jenkins Update LOG class Store the writer output path in a separate key per branch Undo port change for test port Update protobuf extension Style changes and refactors around PR comments Code cleanup with regards to comments on PR Update imports to match style guide Fix import order to match style guide Rename BaseDataWriter to FsDataWriter Add code comment
@zliu41 @liyinan926 rebased it all into one commit. This PR is good from my end. Let me know if you guys have any last minute comments. |
LGTM. Thanks. |
LGTM. |
} | ||
|
||
// Setting the same HDFS properties as the original file | ||
WriterUtils.setFileAttributesFromState(properties, fs, outputFile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked in the code that the preservation of file attributes part has been removed.
I just wanted to confirm whether the removal of setFileAttributesFromState was intentional. The changes were made as part of the feature: Support for having file attributes in the State object #131 (#131) If yes, then WriterUtils.setFileAttributesFromState is no longer required. If no, then this needs to be fixed.
A simple data writer which writes records as byte[] to a file. This also has some refactors around some of the common elements between writers. Adds a new configuration option to add the writer's final output path to the task properties. This can be used by a publisher to read the write file for a task.