Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOBBLIN-286] fix bug where non hive dataset publishing gives NPE #2148

Closed
wants to merge 1 commit into from
Closed

[GOBBLIN-286] fix bug where non hive dataset publishing gives NPE #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopyEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public static List<CopyEntity> deserializeList(String serialized) {
*/
public static String getSerializedWithNewPackage(String serialized) {
serialized = serialized.replace("\"gobblin.data.management.", "\"org.apache.gobblin.data.management.");
log.info("Serialized updated copy entity: " + serialized);
log.debug("Serialized updated copy entity: " + serialized);
return serialized;
}

Expand Down
2 changes: 1 addition & 1 deletion ...gement/src/main/java/org/apache/gobblin/data/management/copy/CopyableDatasetMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static CopyableDatasetMetadata deserialize(String serialized) {
*/
private static String getSerializedWithNewPackage(String serialized) {
serialized = serialized.replace("\"gobblin.data.management.", "\"org.apache.gobblin.data.management.");
log.info("Serialized updated copy entity: " + serialized);
log.debug("Serialized updated copy entity: " + serialized);
return serialized;
}
}
4 changes: 3 additions & 1 deletion ...nt/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,9 @@ private void publishFileSet(CopyEntity.DatasetAndPartition datasetAndPartition,
// Dataset Output path is injected in each copyableFile.
// This can be optimized by having a dataset level equivalent class for copyable entities
// and storing dataset related information, e.g. dataset output path, there.
if (!fileSetRoot.isPresent()) {

// Currently datasetOutputPath is only present for hive datasets.
if (!fileSetRoot.isPresent() && copyableFile.getDatasetOutputPath() != null) {
fileSetRoot = Optional.of(copyableFile.getDatasetOutputPath());
}
}
Expand Down