Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-344] Fix help method getResolver in LineageInfo is private #2200

Closed
wants to merge 1 commit into from

Conversation

zxcware
Copy link
Contributor

@zxcware zxcware commented Dec 12, 2017

Dear Gobblin maintainers,

JIRA

Description

Tests

  • My PR does not need testing for this extremely good reason:
    • No logic change at all

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@zxcware
Copy link
Contributor Author

zxcware commented Dec 12, 2017

@htran1 Please review

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@asfgit asfgit closed this in 49e0f5b Dec 12, 2017
@zxcware zxcware deleted the line branch January 2, 2018 19:38
autumnust pushed a commit to autumnust/gobblin that referenced this pull request Jan 9, 2018
autumnust pushed a commit to autumnust/gobblin that referenced this pull request Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants