Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOBBLIN-633: Provide HOCON support for flow requests to GaaS. #2503

Closed
wants to merge 2 commits into from
Closed

GOBBLIN-633: Provide HOCON support for flow requests to GaaS. #2503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c79182c
GOBBLIN-633: Provide HOCON support for flow requests to GaaS.
Nov 20, 2018
da3e3b0
GOBBLIN-633: Removed unnecessary import.
Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...rvice-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,9 @@ public static FlowSpec createFlowSpecForConfig(FlowConfig flowConfig) {
}

Config config = configBuilder.build();
Config configWithFallback = config.withFallback(ConfigFactory.parseMap(flowConfig.getProperties()));

//We allow for flowConfig to be in HOCON format. We first convert the StringMap object to a String object and
// then use ConfigFactory#parseString() to parse the HOCON string.
Config configWithFallback = config.withFallback(ConfigFactory.parseString(flowConfig.getProperties().toString()).resolve());
try {
URI templateURI = new URI(flowConfig.getTemplateUris());
return FlowSpec.builder().withConfig(configWithFallback).withTemplate(templateURI).build();
Expand Down