New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-1207] Clear references to potentially large objects in Fork,… #3052
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
129 changes: 129 additions & 0 deletions
129
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.gobblin.runtime.fork; | ||
|
||
import java.io.IOException; | ||
import lombok.Getter; | ||
import lombok.Setter; | ||
import org.apache.gobblin.configuration.ConfigurationKeys; | ||
import org.apache.gobblin.configuration.WorkUnitState; | ||
import org.apache.gobblin.converter.DataConversionException; | ||
import org.apache.gobblin.runtime.ExecutionModel; | ||
import org.apache.gobblin.runtime.TaskContext; | ||
import org.apache.gobblin.writer.DataWriter; | ||
import org.apache.gobblin.writer.DataWriterBuilder; | ||
import org.apache.gobblin.writer.RetryWriter; | ||
import org.junit.Assert; | ||
import org.testng.annotations.DataProvider; | ||
import org.testng.annotations.Test; | ||
|
||
|
||
public class ForkTest { | ||
@DataProvider(name = "closeConfigProvider") | ||
public static Object[][] closeConfigProvider() { | ||
// {close on done, expected count} | ||
return new Object[][]{{"true", 1}, {"false", 0}}; | ||
} | ||
|
||
@Test(dataProvider = "closeConfigProvider") | ||
public void TestForCloseWriterTrue(String closeConfig, int expectedCloseCount) throws Exception { | ||
WorkUnitState wus = new WorkUnitState(); | ||
wus.setProp(ConfigurationKeys.FORK_CLOSE_WRITER_ON_COMPLETION, closeConfig); | ||
wus.setProp(ConfigurationKeys.JOB_ID_KEY, "job2"); | ||
wus.setProp(ConfigurationKeys.TASK_ID_KEY, "task1"); | ||
wus.setProp(RetryWriter.RETRY_WRITER_ENABLED, "false"); | ||
wus.setProp(ConfigurationKeys.WRITER_EAGER_INITIALIZATION_KEY, "true"); | ||
wus.setProp(ConfigurationKeys.WRITER_BUILDER_CLASS, DummyDataWriterBuilder.class.getName()); | ||
|
||
TaskContext taskContext = new TaskContext(wus); | ||
Fork testFork = new TestFork(taskContext, null, 0, 0, ExecutionModel.BATCH); | ||
|
||
Assert.assertNotNull(testFork.getWriter()); | ||
|
||
testFork.run(); | ||
|
||
Assert.assertEquals(expectedCloseCount, DummyDataWriterBuilder.getWriter().getCloseCount()); | ||
} | ||
|
||
private static class TestFork extends Fork { | ||
|
||
public TestFork(TaskContext taskContext, Object schema, int branches, int index, ExecutionModel executionModel) | ||
throws Exception { | ||
super(taskContext, schema, branches, index, executionModel); | ||
} | ||
|
||
@Override | ||
protected void processRecords() throws IOException, DataConversionException { | ||
} | ||
|
||
@Override | ||
protected boolean putRecordImpl(Object record) throws InterruptedException { | ||
return true; | ||
} | ||
} | ||
|
||
public static class DummyDataWriterBuilder extends DataWriterBuilder<String, Integer> { | ||
private static ThreadLocal<DummyWriter> myThreadLocal = ThreadLocal.withInitial(() -> new DummyWriter()); | ||
|
||
@Override | ||
public DataWriter<Integer> build() throws IOException { | ||
getWriter().setCloseCount(0); | ||
return getWriter(); | ||
} | ||
|
||
public static DummyWriter getWriter() { | ||
return myThreadLocal.get(); | ||
} | ||
} | ||
|
||
private static class DummyWriter implements DataWriter<Integer> { | ||
@Getter | ||
@Setter | ||
private int closeCount = 0; | ||
|
||
DummyWriter() { | ||
} | ||
|
||
@Override | ||
public void write(Integer record) throws IOException { | ||
} | ||
|
||
@Override | ||
public void commit() throws IOException { | ||
} | ||
|
||
@Override | ||
public void cleanup() throws IOException { | ||
} | ||
|
||
@Override | ||
public long recordsWritten() { | ||
return 0; | ||
} | ||
|
||
@Override | ||
public long bytesWritten() throws IOException { | ||
return 0; | ||
} | ||
|
||
@Override | ||
public void close() throws IOException { | ||
this.closeCount++; | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention in this file doesn't seem to be right. Can you fix it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.