Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1372] Generalization of GobblinClusterUtils#setSystemProperties #3213

Closed
wants to merge 1 commit into from

Conversation

autumnust
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

https://issues.apache.org/jira/browse/GOBBLIN-1372

Description

This PR mainly is for refactoring the method GobblinClusterUtils#setSystemProperties. The problem was: There are some unnecessary details being exposed: JAVA_TMP_DIR_KEY and resolution of YARN_CACHE are all very specific to Gobblin-on-YARN applications. These things shouldn't be set through if-branch but through configurations only.

After refactoring:
There's no specific key/value matching within setSystemProperties method, and we don't lose the capability for limiting resolution of YARN_CACHE only for a specific set of configuration with being backward-compatible.

Also, the refactor also let the program to set additional configuration with value specified as YARN_CACHE using the following pairs:

gobblin.cluster.systemPropertiesList.YARN_CACHE=grape.root
gobblin.cluster.sysProps.grape.root=YARN_CACHE

If trying to achieve the same purpose as -Dgrape.root=YARN_CACHE

Also, it adds a bunch of entries in the .gitignore file.

Tests

Unit tested with resolution cases.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@autumnust
Copy link
Contributor Author

@sv2000 @Will-Lo Please help take a look, thanks

@codecov-io
Copy link

Codecov Report

Merging #3213 (6a263e7) into master (f4c7513) will increase coverage by 32.72%.
The diff coverage is 92.30%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3213       +/-   ##
=============================================
+ Coverage      9.17%   41.89%   +32.72%     
- Complexity     1738     8908     +7170     
=============================================
  Files          2019     2019               
  Lines         77506    77524       +18     
  Branches       8607     8610        +3     
=============================================
+ Hits           7109    32477    +25368     
+ Misses        69701    41985    -27716     
- Partials        696     3062     +2366     
Impacted Files Coverage Δ Complexity Δ
...rg/apache/gobblin/cluster/GobblinClusterUtils.java 87.03% <92.30%> (+34.25%) 13.00 <5.00> (+4.00)
.../org/apache/gobblin/util/filters/HiddenFilter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...g/apache/gobblin/cluster/HelixMessageSubTypes.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...gobblin/runtime/mapreduce/GobblinOutputFormat.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
.../gobblin/compaction/suite/CompactionSuiteBase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
...obblin/compaction/source/CompactionFailedTask.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...n/cluster/event/ClusterManagerShutdownRequest.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...blin/compaction/mapreduce/RecordKeyMapperBase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...in/compaction/action/CompactionCompleteAction.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...n/compaction/mapreduce/orc/OrcKeyDedupReducer.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
... and 1176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c7513...6a263e7. Read the comment docs.

Copy link
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM.

@asfgit asfgit closed this in 26c22ef Jan 26, 2021
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants