Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a config to set MR jobs jar path in CompactionSource #3597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a config to set MR jobs jar path in CompactionSource #3597

wants to merge 1 commit into from

Conversation

arjun4084346
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

umustafi
umustafi approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@umustafi umustafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

gobblin-compaction/src/main/java/org/apache/gobblin/compaction/source/CompactionSource.java
return new BasicWorkUnitStream.Builder(workUnitIterator).build();
WorkUnitStream workUnitStream = new BasicWorkUnitStream.Builder(workUnitIterator).build();
if (workUnitStream.getWorkUnits().hasNext()) {
// copy jars iff workunits are created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo if

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this to save time for 0 workunit jobs? add a bit more reasoning for why in comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umustafi umustafi umustafi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arjun4084346 @umustafi