GORA-509: Upgrade solr library to 6.5.1 #104

madhawa-gunasekara · 2017-05-28T06:38:01Z

No description provided.

lewismc

Thank you @madhawa-gunasekara this is looking good.
Can you also please just remove the existing gora-solr module and rename gora-solr-5 to gora-solr?

lewismc · 2017-05-29T04:31:21Z

gora-solr-5/src/test/conf/solr6/Employee/conf/managed-schema

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>


Please add license header

lewismc · 2017-05-29T04:31:48Z

gora-solr-5/src/test/conf/solr6/Employee/conf/stopwords.txt

@@ -0,0 +1,14 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more


Is this file required if there is nothing in it?

lewismc · 2017-05-29T04:32:10Z

gora-solr-5/src/test/conf/solr6/WebPage/conf/managed-schema

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>


Add license header please

lewismc · 2017-05-29T04:32:39Z

gora-solr-5/src/test/conf/solr6/WebPage/conf/stopwords.txt

@@ -0,0 +1,14 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more


Do we need this if there is nothing in it?

lewismc · 2017-05-29T04:32:51Z

gora-solr-5/src/test/conf/solr6/collection1/conf/managed-schema

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>


License header please.

lewismc · 2017-05-29T04:34:23Z

gora-solr-5/src/test/java/org/apache/gora/solr/GoraSolr6TestDriver.java

+/**
+ * Created by madhawa on 5/28/17.
+ */
+public class GoraSolr6TestDriver extends GoraSolrTestDriver {


Please can you make sure your code is formatted using 2 space indents?

lewismc · 2017-05-29T04:35:38Z

gora-solr-5/src/test/java/org/apache/gora/solr/store/TestSolr6Store.java

+              + "not only removes the data but also the data structure.", 0, page.getOutlinks().size());
+      assertEquals(0, page.getParsedContent().size());
+      if (page.getContent() != null) {
+        LOG.info("url:" + page.getUrl().toString());


Please use parameterized logging as follows

LOG.info("url: {}", page.getUrl().toString());

lewismc · 2017-05-29T04:36:33Z

pom.xml

@@ -739,12 +739,12 @@
    <!-- Solr Dependencies -->
    <lucene-solr.version>4.10.3</lucene-solr.version>


Please remove the old lucene-solr.version

lewismc · 2017-05-29T04:36:50Z

pom.xml

-    <lucene-solr-5.version>5.5.1</lucene-solr-5.version>
-    <solr-solrj-5.version>5.5.1</solr-solrj-5.version>
-    <jetty.version>8.1.8.v20121106</jetty.version>
+    <lucene-solr-5.version>6.5.1</lucene-solr-5.version>


Please rename this to lucene-solr.version

lewismc · 2017-05-29T04:37:33Z

pom.xml

-    <jetty.version>8.1.8.v20121106</jetty.version>
+    <lucene-solr-5.version>6.5.1</lucene-solr-5.version>
+    <solr-solrj-5.version>6.5.1</solr-solrj-5.version>
+    <jetty.version>9.3.14.v20161028</jetty.version>
    <tika.version>1.7</tika.version>


If Tika is a transient dependency made available through Solr (which I think it most definitely is), please make sure to make the update here as well.

madhawa-gunasekara · 2017-05-29T20:13:20Z

@lewismc
I have done the suggested changes. Let me know if you have any concerns.

Thanks,
Madhawa

djkevincr · 2017-05-29T21:44:17Z

@madhawa-gunasekara great work :) Thanks for the PR.

djkevincr · 2017-06-01T09:36:46Z

@lewismc Are you done reviewing the PR? Shall I proceed merging this to master?

lewismc · 2017-06-01T16:27:09Z

+1

djkevincr · 2017-06-04T16:31:20Z

@madhawa-gunasekara I am getting following error when I build the PR changes locally can you please check?

[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Gora :: Tutorial 0.8-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: http://repo.maven.apache.org/maven2/org/apache/solr/solr-core/${lucene-solr-5.version}/solr-core-${lucene-solr-5.version}.pom
Downloading: http://maven.restlet.org/org/apache/solr/solr-core/${lucene-solr-5.version}/solr-core-${lucene-solr-5.version}.pom
Downloading: http://repo.maven.apache.org/maven2/org/apache/solr/solr-solrj/${solr-solrj-5.version}/solr-solrj-${solr-solrj-5.version}.pom
Downloading: http://maven.restlet.org/org/apache/solr/solr-solrj/${solr-solrj-5.version}/solr-solrj-${solr-solrj-5.version}.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Gora :: Tutorial ........................... FAILURE [3.183s]
[INFO] Apache Gora :: Sources-Dist ....................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.005s
[INFO] Finished at: Sun Jun 04 21:44:49 IST 2017
[INFO] Final Memory: 25M/334M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project gora-tutorial: Could not resolve dependencies for project org.apache.gora:gora-tutorial:bundle:0.8-SNAPSHOT: Failed to collect dependencies for [org.apache.gora:gora-core:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-hbase:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-jcache:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-couchdb:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-cassandra:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-solr-5:jar:0.8-SNAPSHOT (compile), org.apache.hadoop:hadoop-client:jar:2.5.2 (compile), org.apache.avro:avro:jar:1.8.1 (compile), org.apache.spark:spark-core_2.10:jar:1.4.1 (provided), org.jdom:jdom:jar:1.1.3 (compile), org.slf4j:slf4j-log4j12:jar:1.6.6 (compile), log4j:log4j:jar:1.2.16 (compile), org.ektorp:org.ektorp:jar:1.4.2 (compile)]: Failed to read artifact descriptor for org.apache.solr:solr-core:jar:${lucene-solr-5.version}: Could not transfer artifact org.apache.solr:solr-core:pom:${lucene-solr-5.version} from/to central (http://repo.maven.apache.org/maven2): Illegal character in path at index 63: http://repo.maven.apache.org/maven2/org/apache/solr/solr-core/${lucene-solr-5.version}/solr-core-${lucene-solr-5.version}.pom -> [Help 1]

madhawa-gunasekara · 2017-06-04T16:34:51Z

@djkevincr I have fixed it :)

djkevincr

Merged the PR. Thank you very much @madhawa-gunasekara :)

madhawa-gunasekara · 2017-06-04T17:12:06Z

@djkevincr Thanks a lot 👍

lewismc requested changes May 29, 2017

View reviewed changes

madhawa-gunasekara force-pushed the solr6 branch 3 times, most recently from 30480f0 to d07787f Compare May 29, 2017 20:12

madhawa-gunasekara and others added 4 commits June 4, 2017 20:13

GORA-509: Upgrade solr library to 6.5.1

47d6d67

Add managed schema tests

a4b26e6

Fix code reviews

c506f44

Remove old solr module and Rename solr5 module into solr module

3b2f282

madhawa-gunasekara force-pushed the solr6 branch from d07787f to 3b2f282 Compare June 4, 2017 14:53

Remove unwanted methods in TestSolrStore

9e95efe

madhawa-gunasekara force-pushed the solr6 branch from ad1eecf to 9e95efe Compare June 4, 2017 16:33

asfgit merged commit 9e95efe into apache:master Jun 4, 2017

djkevincr reviewed Jun 4, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GORA-509: Upgrade solr library to 6.5.1 #104

GORA-509: Upgrade solr library to 6.5.1 #104

madhawa-gunasekara commented May 28, 2017

lewismc left a comment

lewismc May 29, 2017

madhawa-gunasekara May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

lewismc May 29, 2017

madhawa-gunasekara commented May 29, 2017

djkevincr commented May 29, 2017

djkevincr commented Jun 1, 2017

lewismc commented Jun 1, 2017

djkevincr commented Jun 4, 2017

madhawa-gunasekara commented Jun 4, 2017

djkevincr left a comment

madhawa-gunasekara commented Jun 4, 2017

		@@ -0,0 +1,14 @@
		# Licensed to the Apache Software Foundation (ASF) under one or more

		@@ -739,12 +739,12 @@
		<!-- Solr Dependencies -->
		<lucene-solr.version>4.10.3</lucene-solr.version>

GORA-509: Upgrade solr library to 6.5.1 #104

GORA-509: Upgrade solr library to 6.5.1 #104

Conversation

madhawa-gunasekara commented May 28, 2017

lewismc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madhawa-gunasekara commented May 29, 2017

djkevincr commented May 29, 2017

djkevincr commented Jun 1, 2017

lewismc commented Jun 1, 2017

djkevincr commented Jun 4, 2017

madhawa-gunasekara commented Jun 4, 2017

djkevincr left a comment

Choose a reason for hiding this comment

madhawa-gunasekara commented Jun 4, 2017