GORA-667 Revert GORA-271 changes in hbase-store #226
Conversation
…ping loading from configuration
|
Hi, @podorvanova , thank you! :D |
|
@alfonsonishikawa, thank you for your answer! |
I see you added the test to MongoDB store in #231 Looks good to me, then. If no one has anything more to comment, I will merge tomorrow. |
| @@ -887,7 +901,7 @@ private HBaseMapping readMapping(String filename) throws IOException { | |||
| LOG.error("Error while trying to read the mapping file {}. " | |||
| + "Expected to be in the classpath " | |||
| + "(ClassLoader#getResource(java.lang.String)).", | |||
| filename) ; | |||
| mappingStream) ; | |||
There was a problem hiding this comment.
IMO, we should use a different log message, the object mappingStream will not have a human readable content.
There was a problem hiding this comment.
Yes, you are right. I fixed the log message.
|
@alfonsonishikawa, I added a test for HBase store as well. |
|
Merged to master. Thank you, @podorvanova, for the fix! |
This PR still uses DataStoreFactory.getMappingFile() method, when retrieving the filename for the mapping file from the properties file, but also allows to load mappings from properties instead of only from files.