New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GORA-665] - Add support for the Ignite datastore in GoraExplorer #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mgov88 I find we will need the metadata analyzer for Ignite too to have fully support of the features related to GoraExplorer. |
@alfonsonishikawa Hi, I took a look of HBase metadata analyzer https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStoreMetadataAnalyzer.java I there are two methods to be implemented: getTablesNames is just a list of the tables is it correct? |
It is correct but that is specific for HBase. The first method, The second method, The rule of thumb is that It could be, columns and types of each column, for example. Or columns, type, sizes, etc... |
Oh! And the primary key! |
@alfonsonishikawa I developed the Metadata Analyzer feature and a test, I had to update the ignite version, I can not find the schema information of the tables in the older version. |
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteTableMetadata.java
Show resolved
Hide resolved
Merged to master. Thank you, @mgov88 ! |
public static String createSelectAllColumnsOfTable(String schemaIgnite, String table) { | ||
DbSpec spec = new DbSpec(); | ||
DbSchema schema = spec.addDefaultSchema(); | ||
DbTable aTable = schema.addTable("INFORMATION_SCHEMA.COLUMNS"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't spare variables names. Long are the days when each byte was worth and today memory and disk are cheap. Use descriptive meaningful variables to enhance readability.
To add support for Apache Ignite in Gora Explorer the mapping XML must be read from gora.mapping in the same way as is implemented in the Kudu datastore.