GORA-664 Add datastore for Elasticsearch #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create ElasticsearchStore class with connection initialization - Create basic Elasticsearch types mapping - Implement the necessary files for mapping representation (ElasticsearchMapping, ElasticsearchMappingBuilder) - Read schema from mapping file - Cover initialization with test
- Created gora.properties file with configuration properties - Loaded connection parameters from configuration - Implemented connection to Elasticsearch cluster with ElasticsearchParameters - Covered ElasticsearchParameters with tests - Added javadoc descriptions
- Added testing dependencies - Added GoraElasticsearchTestDriver with Elasticsearch container - Added javadoc descriptions to GoraElasticsearchTestDriver class - Fixed two existing tests in accordance to Elasticsearch container
Implemented schemaExists, createSchema, deleteSchema and flush methods
- Relocated gora-elasticsearch.xsd file to main resources - Covered XSD validation with test - Added gora-elasticsearch-mapping-invalid.xml file for test
- Set up password to Elasticsearch container properly - Set default Elasticsearch container server’s username in gora.properties - Added exceptions for missing arguments in authentication
- Defined a parameter for the XSD validation - Added a test case for the parameter - Made ElasticsearchStore read mapping file from properties, not configuration
- Implemented delete, get and put methods - Implemented newInstance and getUnionSchema utility methods - Implemented basic serialization/deserialization for primitive AVRO types
- Added mappings while creating an Elasticsearch index - Added getter and setter to Datatype enum
- Implemented serializeFieldValue and deserializeFieldValue methods for ARRAY, BOOLEAN, BYTES and FIXED Avro data types - Fixed deserialization for STRING Avro data type - Added javadoc descriptions
kamaci
reviewed
May 14, 2021
| break; | ||
| } | ||
| } | ||
|
|
kamaci
reviewed
May 14, 2021
| public float getProgress() { | ||
| if (persistentObjects.size() == 0) { | ||
| return 1; | ||
| } else { |
There was a problem hiding this comment.
No need to write else. It can be:
if (persistentObjects.size() == 0) {
return 1;
}
return offset / (float) persistentObjects.size();
kamaci
reviewed
May 14, 2021
| } catch (IOException ex) { | ||
| throw new GoraException(ex); | ||
| } | ||
| assert response != null; |
There was a problem hiding this comment.
Consider logging and throwing an error without using assert.
|
Congrats @podorvanova for the PR! |
|
Thanks @kamaci for your feedback! I have updated the PR. |
djkevincr
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Outreachy Winter 2020-2021]
This PR implements an Apache Elasticsearch datastore for Apache Gora.
Your feedback would be much appreciated.