Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORA-501 Fix Javadoc for JDK1.8 #93

Merged
merged 2 commits into from Feb 1, 2017
Merged

Conversation

djkevincr
Copy link
Member

@djkevincr djkevincr commented Jan 29, 2017

Seems like there are many javadoc related issues are still there in the code base. Will work on the rest once got some time. :) Also I have excluded generating javadocs for generated class packages.

@lewismc
Copy link
Member

lewismc commented Jan 29, 2017

Thank you for marking the exclusion in the Javadoc @djkevincr
+1 in favour of merging into master :)

@lewismc
Copy link
Member

lewismc commented Jan 30, 2017

Please merge into master @djkevincr

@djkevincr
Copy link
Member Author

@lewismc Please note I have excluded only for goraci and tutorial generated packages. So there are many javadoc issues left in other packages as well. How do we proceed with this? Ignore all doclint warnings? ( -Xdoclint:none option ) Anyway I can work on fixing the rest.

@lewismc
Copy link
Member

lewismc commented Feb 1, 2017

I think your patch fixes the error's which lead to the build failing. The remaining Javadoc issues relate to warning's... which for the sake of getting the build back to stable are acceptable for the time being. Can you please merge this patch into master if you get a chance? I've just pulled it locally and mvn javadoc:aggregate builds well.

@djkevincr
Copy link
Member Author

+1 will merge now

@asfgit asfgit merged commit f8706c9 into apache:master Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants