Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Refactor the table implementation in spark-connector #2845

Open
caican00 opened this issue Apr 9, 2024 · 0 comments
Open

[Improvement] Refactor the table implementation in spark-connector #2845

caican00 opened this issue Apr 9, 2024 · 0 comments
Labels
improvement Improvements on everything

Comments

@caican00
Copy link
Contributor

caican00 commented Apr 9, 2024

What would you like to be improved?

Refactor the table implementation in spark-connector.

The purpose of inheritance SparkTable is in order to go through the isIcebergTable check in IcebergSparkSqlExtensionsParser.

For details, please refer to: https://github.com/apache/iceberg/blob/main/spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala#L127-L186

Without refactoring, row-level operations cannot be performed.

How should we improve?

No response

@caican00 caican00 added the improvement Improvements on everything label Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
1 participant