For task GRIFFIN-229, trigger the job right now #480
Conversation
| @@ -113,4 +113,10 @@ public JobHealth getHealthInfo() { | |||
| .contentType(MediaType.APPLICATION_OCTET_STREAM) | |||
| .body(resource); | |||
| } | |||
|
|
|||
| @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.GET) | |||
There was a problem hiding this comment.
The job trigger process is not idempotent, "GET" method seems not proper here. I think "POST" method would be better, as it creates a job submission.
|
@dyingbleed can you please include screenshots for UI changes? |
|
@dyingbleed That's quite useful feature, and I think many people would really like to see it in upstream. If you don't have time for finishing it, me or @dershovGD can help getting it to completion. |
| @@ -113,4 +113,10 @@ public JobHealth getHealthInfo() { | |||
| .contentType(MediaType.APPLICATION_OCTET_STREAM) | |||
| .body(resource); | |||
| } | |||
|
|
|||
| @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.GET) | |||
| @ResponseStatus(HttpStatus.NO_CONTENT) | |||
There was a problem hiding this comment.
I think it makes sense to see how we can return jobinstance information from this method, so it would be possible to wait for job's status via api.
|
@bhlx3lyx7 @guoyuepeng We'd like to see GRIFFIN-229 in upstream faster, but original PR author is not responding. What's the policy in this case? Can we take available commit, add commits ontop of it, and send PR, or it should be independent implementation? |
|
@chemikadze @dyingbleed @bhlx3lyx7 For this feature development, I think we can add commits on top of it. |
[comment](#480 (comment)) > dyingbleed can you please include screenshots for UI changes? <img width="1074" alt="screen shot 2019-03-06 at 18 19 25" src="https://user-images.githubusercontent.com/43031807/53944639-d4424980-40d0-11e9-977e-29b45b879bf9.png"> <img width="1065" alt="screen shot 2019-03-06 at 18 43 23" src="https://user-images.githubusercontent.com/43031807/53944659-db695780-40d0-11e9-9114-43879cf068fa.png"> Author: Borgatin Alexandr <aborgatin@griddynamics.com> Author: Alexandr Borgatin <43031807+aborgatin@users.noreply.github.com> Author: Anthony Li <lizhen.dgut@gmail.com> Closes #485 from aborgatin/feature/GRIFFIN-229.
|
Closed by #485 |
No description provided.