New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GRIFFIN-273] Griffin Service with user-defined log4j2 configuration #518
Conversation
hi Joohnnie, |
…ring log system is not initialized yet.
Hi William, Thanks |
Thanks, Johnnie. |
It seems that your configuration is based on the default configuration of spring boot, I think there is no problem with the content. But I'm not sure if giving an implementation like what you do or giving a guide in a document is better, cause If users want customized log, they may still need to make some changes in these files. |
@whhe Thanks for your comments. Regarding the guild, log4j2 is an open-source library and has its official website. |
@@ -82,6 +82,10 @@ under the License. | |||
</exclusion> | |||
</exclusions> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
LGTM. |
Currently, the Griffin service module use spring-boot default log4j2 configuration.
This approach is not easy to change the config for debugging and add new appender such as
RollingFile