Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java13 build #1139

Closed
wants to merge 2 commits into from
Closed

Add Java13 build #1139

wants to merge 2 commits into from

Conversation

daniellansun
Copy link
Contributor

  1. As we do not have enough time to migrate gradle from 5.6.4 to 6.x, we decide to build Groovy with Java 11 and run tests with Java 13. BTW, volunteers to help Apache Groovy polish the Gradle build scripts are always welcome.
  2. Java 13 introduces some new API, e.g. String::stripIndent, which has conflicts with GDK's existing method. As a workaround, we add a incubating variant of stripIndent in GDK.

@asfgit asfgit closed this in 3d85ccb Jan 22, 2020
asfgit pushed a commit that referenced this pull request Jan 22, 2020
@eric-milles eric-milles deleted the java13-build branch February 11, 2020 19:14
jord1e added a commit to jord1e/graphql-java that referenced this pull request Jan 31, 2022
Fixed:
- Generic warnings introduced in Java 9 when using `Stream#of` is used in combination with `Function.identity()`, probably caused by JEP 215 "Tiered Attribution for javac"
- Java 13 introduced `String#stripIndent`, which conflicted with Groovy itself, see apache/groovy#1139, the errors were probably caused by whitespace indentation which was handled differently
- Resolved compiler warning about missing `@Deprecated` on deprecated `ExecutionStepInfo#getFieldContainer` method (JDK 9/JEP 277 "Enhanced Deprecation")
- The wrong `BigInteger` constructor was being used in `ScalarIntTest.groovy` and `ScalarFloatTest.groovy`

Not yet fixed:
- Java 16 modified LineNumberReader#getLineNumber behavior (see JDK-8241020) which messed up MultiSourceReader

Links:
- apache/groovy#1139
- https://bugs.openjdk.java.net/browse/JDK-8241020
- https://github.com/openjdk/jdk/commits/master/src/java.base/share/classes/java/io/LineNumberReader.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant