Allow security managers to prevent system property access for Indy #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pickypg Thanks for this pull request. I created https://issues.apache.org/jira/browse/GROOVY-7626 to track this. |
|
Thanks for the pull request. :) Sorry for taking so long to merge. :( The fix will be in the next release (2.4.6). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
"indy"setting, it tries to read a system property to enable logging.This change enables a JVM Security Manager to block this setting and therefore simply ignore the setting to use the default: do not log.
From a security manager, you might otherwise catch a
SecurityExceptioncontaining:Not only is this not recoverable, but the
IndyInterfaceclass will be inaccessible thereafter due to it being in astaticblock that fails (the dreadedNoClassDefFoundError).