GROOVY-9546: groovydoc: fix annotation rendering #1243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created a separate issue for the missing property annotations, since I couldn't yet figure it out: https://issues.apache.org/jira/browse/GROOVY-9548 |
paulk-asert
reviewed
May 11, 2020
| import groovy.transform.NamedVariant | ||
|
|
||
| // The annotations that are used here don't really matter, | ||
| // since groovydoc shows all annotations, not just @Documented ones. |
There was a problem hiding this comment.
We do plan to correct @documented behaviour one day. We currently try to minimise resolving classes when not needed but we will likely change that at some point.
There was a problem hiding this comment.
Got it! GROOVY-4634 is probably it, then.
|
Merged. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at fixing the annotation rendering.
Somehow the annotations are not shown on properties at all.
Let me know if this is too hacky.