Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GROOVY-10216: Avoid unnecessary security checks for each invocation #1618

Closed
wants to merge 1 commit into from
Closed

GROOVY-10216: Avoid unnecessary security checks for each invocation #1618

wants to merge 1 commit into from

Conversation

daniellansun
Copy link
Contributor

No description provided.

@asfgit asfgit force-pushed the danielsun/avoid-unnecessary-security-checks branch 2 times, most recently from 5393af7 to a14a506 Compare September 8, 2021 07:49
@asfgit asfgit force-pushed the danielsun/avoid-unnecessary-security-checks branch from a14a506 to 6870410 Compare September 8, 2021 07:52
@eric-milles
Copy link
Member

So if isAccessible() returns true, you still should be calling setAccessible(true)? What are the security checks that are tried for an accessible object? Do you have any documentation on this behavior?

Also, what do the rows and values in the performance chart represent? I'm not clear on what the data is intended to communicate.

@daniellansun daniellansun deleted the danielsun/avoid-unnecessary-security-checks branch September 16, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@daniellansun @eric-milles