GROOVY-10813: Fix NullPointerException for lambdas with raw types #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-milles
requested changes
Nov 11, 2022
Shadow-Devil
force-pushed
the
GROOVY-10813
branch
2 times, most recently
from
76b905d
to
ff7902c
Compare
Shadow-Devil
force-pushed
the
GROOVY-10813
branch
from
ff7902c
to
2031025
Compare
|
I relocated the lambda tests and reworked the generics tests to ensure the placeholders are not returned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a test case and a fix for the bug reported in GROOVY-10813.
I'm not sure if there are any other edge cases that will now break because of this change, but one test, that failed with another solution that I tried, passes with this solution.