GROOVY-10881: Make FastStringUtils work in an OSGi environment

[royteeuwen]

No description provided.

[codecov-commenter]

Codecov Report

Merging #1836 (59d3a32) into master (2727507) will decrease coverage by 0.0003%.
The diff coverage is 33.3333%.

@@                Coverage Diff                 @@
##               master      #1836        +/-   ##
==================================================
- Coverage     67.7583%   67.7580%   -0.0003%     
  Complexity      28281      28281                
==================================================
  Files            1427       1427                
  Lines          112556     112558         +2     
  Branches        19302      19303         +1     
==================================================
+ Hits            76266      76267         +1     
- Misses          29759      29761         +2     
+ Partials         6531       6530         -1     

Impacted Files	Coverage Δ
...g/apache/groovy/json/internal/FastStringUtils.java	55.0000% <33.3333%> (-6.1111%)	⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java	45.0593% <0.0000%> (ø)
...odehaus/groovy/reflection/GeneratedMetaMethod.java	57.6923% <0.0000%> (+0.9615%)	⬆️

[eric-milles]

Can you please make the test class final and JUnit4-based by using @Test instead of GroovyTestCase?

[eric-milles]

Will this cause many passes of class scanning and DefaultFastStringService instances? How are loadService() and getService() used?

[royteeuwen]

Will this cause many passes of class scanning and DefaultFastStringService instances? How are loadService() and getService() used?

INSTANCE s a static field, meaning that at the class loading of FastStringUtils it will be initialized by calling loadService(). This will only be done once

getService() will just return that same static instance all the time

[paulk-asert]

@royteeuwen Should we close this now given the alternative fix?

[royteeuwen]

@royteeuwen Should we close this now given the alternative fix?

Done!