GROOVY-7853: o.c.g.r.t.DefaultTypeTransformation does not apply the r… #345
Conversation
| @@ -41,7 +43,15 @@ public static Class castToClass(Object object) { | |||
|
|
|||
| public static String castToString(Object object) { | |||
| if (object==null) return null; | |||
| if (object instanceof Class) return (String) object; | |||
| if (object instanceof boolean[]) return Arrays.toString((boolean[])object); | |||
There was a problem hiding this comment.
Would it be more efficient to put this within an if(object.getClass().isArray) block?
There was a problem hiding this comment.
Good catch. Yes, that's probably a good optimization. Thanks for the
suggestion.
On Wed, Jun 15, 2016 at 10:27 PM, Jason Winnebeck notifications@github.com
wrote:
In
src/main/org/codehaus/groovy/runtime/typehandling/ShortTypeHandling.java
#345 (comment):@@ -41,7 +43,15 @@ public static Class castToClass(Object object) {
public static String castToString(Object object) { if (object==null) return null;
if (object instanceof Class) return (String) object;if (object instanceof boolean[]) return Arrays.toString((boolean[])object);Would it be more efficient to put this within an
if(object.getClass().isArray) block?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/groovy/pull/345/files/5c914153d3c97708d10cf210cf62989e51008368#r67151385,
or mute the thread
https://github.com/notifications/unsubscribe/AARF0Pnh0PV29an3T3l9GqZFHA3iJZtvks5qL--pgaJpZM4ItMJP
.
|
Updated per (I believe) Jochen's comment in the mailing list. |
…ight toString on primitve arrays when transforming to String
…ight toString on primitve arrays when transforming to String (don't use ShortTypeHandling)
paulk-asert
force-pushed
the
groovy7853
branch
from
752b3e4
to
eec3b1f
Compare
…ight toString on primitve arrays when transforming to String