GROOVY-8288 executeBatch() should not be called with batchCount == 0 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akapps
commented
Aug 15, 2017
| def result = sql.withBatch { ps -> | ||
| // Do nothing - not a good practice at all... | ||
| } | ||
| assert result == [] as int[] |
There was a problem hiding this comment.
It is quite surprising at first sight that HSQL driver behaves differently if executeBatch() is called with nothing added to the batch, whether a preparedStatement is used or not.
I felt like it's not Groovy responsibility to "suppress" the exception for the preparedStatement case, and I wanted to test-specify those 2 behaviours as they are the current ones.
|
Merged. Thanks! |
avafanasiev
pushed a commit
to avafanasiev/groovy
that referenced
this pull request
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first proposition of resolution for GROOVY-8288.
There still are open questions (see my comments on changes).
Thank you for your feedback.