Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.0 related fixes #724

Closed
wants to merge 2 commits into from

Conversation

jwagenleitner
Copy link
Contributor

Some recent commits seem to cause problems with the Nextflow 2.5.0 snapshot builds on the CI server. One can lead to a NPE (commit 90486ae) because fieldNode can be reassigned null after the instanceof check. Another change (commit 57cfd2a) seems to have caused an issue with assigning parameterized types.

@daniellansun
Copy link
Contributor

The PR looks great for me. Out of curiosity, why does the helper method cause the issue(GenericsUtils.extractPlaceholders(GenericsUtils.findParameterizedType(declaringClassForDistance, actualReceiverForDistance)); )? I will set aside some time to investigate.

@jwagenleitner
Copy link
Contributor Author

It was extracting the actual type argument of String rather than the type Trie.

@jwagenleitner jwagenleitner deleted the rel25fixes branch May 26, 2018 03:51
@paulk-asert
Copy link
Contributor

+1, you actually fixed something on my TODO list to look at today! :-)

@daniellansun
Copy link
Contributor

@paulk-asert it's better to add your tests too

@daniellansun
Copy link
Contributor

@jwagenleitner Gotcha 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants