GROOVY-8963: Use CompilerConfiguration.DEFAULT_SOURCE_ENCODING as d…
#856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault encoding
melix
suggested changes
Jan 19, 2019
There was a problem hiding this comment.
-1, this is a breaking change. The default source encoding was assumed to be the system default encoding. With this change just by upgrading Groovy some sources wouldn't build anymore because files encoded with iso-8859-1 (typical Windows) would now use UTF-8. This would have been fine for a default in the beginning, but unfortunately we can't change that.
|
OK, I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…efault encoding