Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy 8180 log to file #886

Closed
wants to merge 2 commits into from
Closed

Conversation

tttao
Copy link
Contributor

@tttao tttao commented Mar 3, 2019

  • Add option in Preferences dialog to append output to file
  • Modified Console to output to file additionnally to classic output

Jira: https://issues.apache.org/jira/browse/GROOVY-8180

@daniellansun
Copy link
Contributor

LGTM

}
}

//console.swing.outputFileName.enabled = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be deleted?

import javax.swing.text.Element
import javax.swing.text.SimpleAttributeSet
import javax.swing.text.Style
import javax.swing.text.StyleConstants
import javax.swing.text.StyledDocument
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

@paulk-asert
Copy link
Contributor

I merged with a few tweaks - thanks!

If you feel like polishing further, I noticed what looked like some extra newlines/whitespace in the file log that I wasn't expecting (perhaps OS specific) - might be worth investigating.

Also, I wonder whether folks would like the checkbox and filename saved under the OS preferences. Might be worth an email to the mailing list to see if folks have a strong preference. At the moment you need to set them each time you start the console.

@tttao
Copy link
Contributor Author

tttao commented Mar 4, 2019

@paulk-asert Thanks for the feedback ! I will drop a mail to the mailing list regarding saving the checkbox+filename under the OS preferences - knowing that it might not be convenient to redirect output for every Console instances to the same log file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants