Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1147: Add support for additional LDAP properties in Docker container #556

Merged
merged 2 commits into from Aug 4, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 29, 2020

Hi !

I need to add this variable to my docker-compose file to use my ldap.
So, I think i'm not alone, so I suggest to add it.

Maybe, it will be useful to add other variable like :

ldap-dereference-aliases
ldap-follow-referrals
ldap-max-referral-hops
ldap-operation-timeout

Thanks for your work !

@necouchman
Copy link
Contributor

@Rwanito: Thanks for the contribution. However, in order for us to work through this you will first need to open a JIRA issue for the changes:

https://issues.apache.org/jira/browse/GUACAMOLE

After that you'll need to tag both the pull request and commit message(s) with the JIRA issue. Full contribution guidelines can be found, here:

http://guacamole.apache.org/open-source/

@ghost ghost changed the title Add ldap-member-attribute-type support for Docker GUACAMOLE-1147: Add ldap-member-attribute-type support for Docker Jul 29, 2020
@ghost
Copy link
Author

ghost commented Jul 29, 2020

Thanks for your reply.
Is it ok, now ?

Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style change request. Also, you mentioned several other properties that you thought might want to be added - would now be a good time to add those?

guacamole-docker/bin/start.sh Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Aug 3, 2020

Hi ! I commited my changes about the spacing et style.
Normally, now there is all ldap attributes from the doc in the start.sh.

@necouchman necouchman changed the title GUACAMOLE-1147: Add ldap-member-attribute-type support for Docker GUACAMOLE-1147: Add support for additional LDAP properties in Docker container Aug 4, 2020
Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Rwanito, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants