-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUACAMOLE-30: Implement systemd startup for guacd #160
Conversation
@@ -0,0 +1,11 @@ | |||
[Unit] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do systemd unit files support comments? Assuming they do, this new file should include the usual license boilerplate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably so...will add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
src/guacd/systemd/guacd.service.in
Outdated
|
||
[Service] | ||
User=daemon | ||
ExecStart=@sbindir@/guacd -f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the generally-accepted best practice? Relying on systemd to handle the daemonization for the process, management of any PID file, etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - most of what I've seen in systemd unit files is that you put the process in foreground mode and allow systemd to manage it. I can't cite a source that says it, just my anecdotal experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Googling around a bit, definitely seems the way of things for systemd: http://www.mikeperham.com/2014/09/22/dont-daemonize-your-daemons/
No description provided.