Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-30: Implement systemd startup for guacd #160

Merged
merged 3 commits into from
Mar 17, 2018

Conversation

necouchman
Copy link
Contributor

No description provided.

@necouchman necouchman changed the title GUACAMOLE-30: Implement systemd script for guacd GUACAMOLE-30: Implement systemd startup for guacd Mar 16, 2018
@@ -0,0 +1,11 @@
[Unit]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do systemd unit files support comments? Assuming they do, this new file should include the usual license boilerplate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably so...will add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.


[Service]
User=daemon
ExecStart=@sbindir@/guacd -f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the generally-accepted best practice? Relying on systemd to handle the daemonization for the process, management of any PID file, etc.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - most of what I've seen in systemd unit files is that you put the process in foreground mode and allow systemd to manage it. I can't cite a source that says it, just my anecdotal experience.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Googling around a bit, definitely seems the way of things for systemd: http://www.mikeperham.com/2014/09/22/dont-daemonize-your-daemons/

@asfgit asfgit merged commit fef819f into apache:master Mar 17, 2018
@necouchman necouchman deleted the jira/30 branch March 17, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants