GUACAMOLE-662: Correct behavior of nested socket. #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nested
guac_socket
implementation has apparently been broken for some time. Besides the index not being properly initialized, the data written to the socket is (incorrectly) immediately flushed as a "nest" instruction. This behavior has resulted in the nested socket unit test failing.These changes correct the above, properly initializing the socket index and properly buffering UTF-8 data for eventual flushing as "nest" instructions.