-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-4253. Add LayoutVersion request/response for DN registration. #1457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prashantpogde , some minor comments from me.
I noticed that PR title is not consistent with HDDS-4253 JIRA title.
...ner-service/src/main/java/org/apache/hadoop/ozone/protocol/StorageContainerNodeProtocol.java
Show resolved
Hide resolved
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @prashantpogde. Approach looks good to me. A couple of suggestions inline.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
Show resolved
Hide resolved
...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
Show resolved
Hide resolved
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
Outdated
Show resolved
Hide resolved
@prashantpogde , the CI failure still happened, due to below socket closed error. Seems not related.
|
is not the cause of failures, it can be ignored. Acceptance tests (secure and unsecure) fail with:
|
It is possible the acceptance test failures are related since the DN registration step is done Recon's underlying SCM as well. |
I am investigating errors and I will fix if any. |
All checks have passed, +1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @prashantpogde. We can refine this in subsequent JIRAs.
What changes were proposed in this pull request?
Add LayoutVersion request/response for DN registration.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4253
How was this patch tested?
tested with existing and updated UTs.