Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4253. Add LayoutVersion request/response for DN registration. #1457

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

prashantpogde
Copy link
Contributor

What changes were proposed in this pull request?

Add LayoutVersion request/response for DN registration.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4253

How was this patch tested?

tested with existing and updated UTs.

Copy link
Contributor

@linyiqun linyiqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prashantpogde , some minor comments from me.
I noticed that PR title is not consistent with HDDS-4253 JIRA title.

Copy link
Contributor

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @prashantpogde. Approach looks good to me. A couple of suggestions inline.

@linyiqun
Copy link
Contributor

linyiqun commented Oct 2, 2020

@prashantpogde , the CI failure still happened, due to below socket closed error. Seems not related.

Exception in thread "main" java.net.SocketException: Socket closed
	at java.net.PlainSocketImpl.socketAccept(Native Method)
	at java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:409)
	at java.net.ServerSocket.implAccept(ServerSocket.java:560)
	at java.net.ServerSocket.accept(ServerSocket.java:528)
	at org.apache.hadoop.test.JacocoServer.main(JacocoServer.java:60)
Error: Process completed with exit code 1.

@adoroszlai
Copy link
Contributor

Exception in thread "main" java.net.SocketException: Socket closed
	at java.net.PlainSocketImpl.socketAccept(Native Method)
	at java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:409)
	at java.net.ServerSocket.implAccept(ServerSocket.java:560)
	at java.net.ServerSocket.accept(ServerSocket.java:528)
	at org.apache.hadoop.test.JacocoServer.main(JacocoServer.java:60)
Error: Process completed with exit code 1.

is not the cause of failures, it can be ignored.

Acceptance tests (secure and unsecure) fail with:

Check if Recon picks up DN heartbeats                                 | FAIL |
'{"totalCount":0,"datanodes":[]}' does not contain 'datanode_1'

@avijayanhwx
Copy link
Contributor

Exception in thread "main" java.net.SocketException: Socket closed
	at java.net.PlainSocketImpl.socketAccept(Native Method)
	at java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:409)
	at java.net.ServerSocket.implAccept(ServerSocket.java:560)
	at java.net.ServerSocket.accept(ServerSocket.java:528)
	at org.apache.hadoop.test.JacocoServer.main(JacocoServer.java:60)
Error: Process completed with exit code 1.

is not the cause of failures, it can be ignored.

Acceptance tests (secure and unsecure) fail with:

Check if Recon picks up DN heartbeats                                 | FAIL |
'{"totalCount":0,"datanodes":[]}' does not contain 'datanode_1'

It is possible the acceptance test failures are related since the DN registration step is done Recon's underlying SCM as well.

@prashantpogde
Copy link
Contributor Author

I am investigating errors and I will fix if any.

@linyiqun
Copy link
Contributor

linyiqun commented Oct 6, 2020

All checks have passed, +1.

Copy link
Contributor

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @prashantpogde. We can refine this in subsequent JIRAs.

@avijayanhwx avijayanhwx merged this pull request into apache:HDDS-3698-upgrade Oct 6, 2020
avijayanhwx pushed a commit to avijayanhwx/hadoop-ozone that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants