Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-2469. Avoid changing client-side key metadata #154

Merged
merged 2 commits into from
Nov 13, 2019
Merged

HDDS-2469. Avoid changing client-side key metadata #154

merged 2 commits into from
Nov 13, 2019

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Let OM RpcClient add extra metadata keys only into the request to OM, not to the input from client.

https://issues.apache.org/jira/browse/HDDS-2469

How was this patch tested?

Tweaked integration tests:

Tests run: 69, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 26.154 s - in org.apache.hadoop.ozone.client.rpc.TestOzoneRpcClient
Tests run: 70, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 27.976 s - in org.apache.hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.035 s - in org.apache.hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog

Also ran ozone smoketest, which includes GDPR test:

ozone-gdpr :: Smoketest Ozone GDPR Feature
==============================================================================
Test GDPR disabled                                                    | PASS |
------------------------------------------------------------------------------
Test GDPR --enforcegdpr=true                                          | PASS |
------------------------------------------------------------------------------
Test GDPR -g=true                                                     | PASS |
------------------------------------------------------------------------------
Test GDPR -g=false                                                    | PASS |
------------------------------------------------------------------------------
ozone-gdpr :: Smoketest Ozone GDPR Feature                            | PASS |
4 critical tests, 4 passed, 0 failed
4 tests total, 4 passed, 0 failed

@adoroszlai
Copy link
Contributor Author

@dineshchitlangia @anuengineer please review

@anuengineer
Copy link
Contributor

Looks good to me, I will wait for @dineshchitlangia to take a quick look too.

dineshchitlangia
dineshchitlangia requested changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Requested minor change inline. The test failures are unrelated to your patch.

...ration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java Outdated Show resolved Hide resolved
dineshchitlangia
dineshchitlangia approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. Committing this to master. Thanks @adoroszlai for contribution and @anuengineer for reviews.

@dineshchitlangia dineshchitlangia merged commit 659385e into apache:master Nov 13, 2019
@adoroszlai adoroszlai deleted the HDDS-2469 branch November 13, 2019 23:49
@adoroszlai
Copy link
Contributor Author

Thanks @dineshchitlangia and @anuengineer for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshchitlangia dineshchitlangia dineshchitlangia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adoroszlai @anuengineer @dineshchitlangia