Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-2481. Close streams in TarContainerPacker #167

Merged
merged 11 commits into from
Nov 14, 2019
Merged

HDDS-2481. Close streams in TarContainerPacker #167

merged 11 commits into from
Nov 14, 2019

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Nov 14, 2019 •
edited
Loading

What changes were proposed in this pull request?

Make sure all streams are closed in TarContainerPacker (571fc90). Plus various refactorings, see list of commits.

https://issues.apache.org/jira/browse/HDDS-2481

How was this patch tested?

Ran TestTarContainerPacker.

anuengineer
anuengineer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@anuengineer anuengineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM. The unit test failure does not seem to be related to this patch. I will commit this now.

@anuengineer anuengineer merged commit 0d86870 into apache:master Nov 14, 2019
@adoroszlai adoroszlai deleted the HDDS-2481 branch November 14, 2019 17:27
@adoroszlai
Copy link
Contributor Author

Thanks @anuengineer for reviewing and committing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuengineer anuengineer anuengineer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adoroszlai @anuengineer