HDDS-2720. Ozone Failure injection Service #956
Conversation
- Minor change to make it work with lower version of libfuse3
There was a problem hiding this comment.
Thank you very much to open this issue. I am very happy that it was decided to move to the umbrella of Ozone.
I had some minor comments, and also two generic one:
-
Directory name: Can you please use full lower case dir names (FaultInjectionService --> fault-injection-service). I am your friend in using linux, but AFAIK the upper-case/lower-case dirs can cause problems on other OS like OSX.
-
Build script: If we have no build script to check it, it can become obsolete over the time. Ideally we need to test it during the builds.
I would be happy to help to include it to the github actions, but can you please provide a very simple script to build this service?. I would suggest to create a hadoop-ozone/dev-support/checks/buildfaultinjection.sh.
Use can use the existing pattern to identify the dir:
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
And add your 1-2 commands (./configure, ./make whatever)
tools/FaultInjectionService/AUTHORS
Outdated
| @@ -0,0 +1,12 @@ | |||
| Current Maintainer | |||
There was a problem hiding this comment.
I am not sure if we need this file (but I can be convinced). Until now we didn't follow this pattern. There are no maintainers of SCM / Freon / OM. The community itself is the maintainers but we can check the git history for first contact.
This file is also requires additional maintenance. I would suggest to remove it.
There was a problem hiding this comment.
@elek Thank you for reviewing it.
- Yes I will remove AUTHORS file and change the directory name to lower case.
- Its supported only on linux and some dependencies require building them from the source. I will add an automated build script as next set of enhancement and create a separate PR.
|
|
||
| About | ||
| ------ | ||
| TBD |
There was a problem hiding this comment.
yup, will change.
|
|
||
| Development Status | ||
| ------------------ | ||
| TBD |
There was a problem hiding this comment.
yup, will change.
|
Thanks the update @prashantpogde
|
|
@elek Thank you for the review. I have made the suggested changes. Please take a look. |
| @@ -0,0 +1,56 @@ | |||
| Fault Injection Service | |||
There was a problem hiding this comment.
ASF licence header is missing from here.
There was a problem hiding this comment.
I noticed that ASF license header was not there in Ozone README.md, Should I put it in this one ?
|
I just found this one on the faq page
It seems that we don't need LICENSE header for that specific README. |
What changes were proposed in this pull request?
Adding Fault Injection Service in Ozone:tools/FaultInjectionService directory
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2720
How was this patch tested?
This is an independent tool which will be used to do fault injection testing for Ozone. Its build/test process is independent of Ozone and should not impact Ozone in any way.
For using this tool, please follow README in tools/FaultInjectionService.