Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-198. Update tony submodule to support MXNet. #11

Closed
wants to merge 1 commit into from

Conversation

yuanzac
Copy link
Contributor

@yuanzac yuanzac commented Sep 25, 2019

What is this PR for?

MXNet(CPU only) is supported by tony now:
tony-framework/TonY@014a850
Let's update the tony submodule.

What type of PR is it?

Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-198

How should this be tested?

https://travis-ci.org/yuanzac/hadoop-submarine/builds/589404537

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@xunliu
Copy link
Member

xunliu commented Sep 26, 2019

@yuanzac Can you test MXNet in mini-submarine?
If it is not supported now, Please create a subtask at https://issues.apache.org/jira/browse/SUBMARINE-164.

@asfgit asfgit closed this in f81f11a Sep 26, 2019
@yuanzac
Copy link
Contributor Author

yuanzac commented Sep 26, 2019

@liuxunorg, jiwq
Thanks a lot for the comments.
I'll try to submit a MXNet job in mini-submarine and give the updates later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants