Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-222. Use virtual Python env in CICD image #36

Closed
wants to merge 1 commit into from

Conversation

tangzhankun
Copy link
Contributor

What is this PR for?

When using the current CICD image, there is a possibility that the merge PR script will fail due to Python environment issue. I propose to use python virtual env to solve this.

What type of PR is it?

Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-222

How should this be tested?

re-build the cicd image and use it to merge PR

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jojochuang
Copy link
Contributor

Looks good.
Instead of downloading virtualenv source code & compile it, you should be able to just install it: as an example: https://gist.github.com/frfahim/73c0fad6350332cef7a653bcd762f08d

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be even better to add environment variables to the container's startup parameters.
Can you update the documentation(https://github.com/apache/hadoop-submarine/tree/master/dev-support/cicd#docker-mode), increase the startup parameters?

@yuanzac
Copy link
Contributor

yuanzac commented Oct 10, 2019

LGTM.
I've tested it. it works.
Thanks @tangzhankun @jojochuang @liuxunorg

@asfgit asfgit closed this in bcb870f Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants